Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Fallbacks#inspect and Fallbacks#empty? #683

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Implement Fallbacks#inspect and Fallbacks#empty? #683

merged 2 commits into from
Mar 5, 2024

Conversation

fatkodima
Copy link
Contributor

See rails/rails#51253.

The output is confusing and always shows as an empty hash:

# In a rails app
config.i18n.fallbacks = { :'en-GB' => [:en], :'en-UK' => [:en], :'en-US' => [:en] }

I18n.fallbacks # => {}
I18n.fallbacks.class # => I18n::Locale::Fallbacks
I18n.fallbacks.instance_variable_get(:@map) # => {:"en-GB"=>[:en], :"en-UK"=>[:en], :"en-US"=>[:en]}

Should we also override empty? method?

@fatkodima fatkodima mentioned this pull request Mar 5, 2024
Closed
@radar
Copy link
Collaborator

radar commented Mar 5, 2024

Yes, I think if empty? is acting in a "surprising" fashion, then we should fix it up here to behave as expected. Happy for you to add this in this PR too.

I noticed the build is failing and I'll get the workflows tidied up today in my own PR.

@fatkodima fatkodima force-pushed the add-inspect-to-fallbacks branch from 420b880 to aca633e Compare March 5, 2024 22:08
@fatkodima fatkodima changed the title Implement custom Fallbacks#inspect Implement Fallbacks#inspect and Fallbacks#empty? Mar 5, 2024
@fatkodima
Copy link
Contributor Author

Added empty? method.

@radar radar force-pushed the add-inspect-to-fallbacks branch from a818376 to aca633e Compare March 5, 2024 22:20
@radar
Merge branch 'master' into add-inspect-to-fallbacks
9e86475 
* master:
  Clearly specify which versions of Ruby + Rails we support
  Add back Ruby 3.0 support
  Use actions/checkout@v4, as Node 16 actions have been deprecated
  Bump Mocha deps to v2 to fix build issue
  Specify racc as a dependency
  Update workflows
@radar radar merged commit 5fb9e63 into ruby-i18n:master Mar 5, 2024
27 of 28 checks passed
@radar
Copy link
Collaborator

radar commented Mar 5, 2024

Thank you!

@fatkodima fatkodima deleted the add-inspect-to-fallbacks branch March 5, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radar radar radar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fatkodima @radar